ystero-dev / hampi

Rust ASN.1 Toolkit
Other
43 stars 18 forks source link

Support ALL EXCEPT constructs #79

Closed xpromache closed 1 year ago

xpromache commented 1 year ago

The following construct is not supported

IdentifierString ::= VisibleString (FROM (ALL EXCEPT " "))

It is used in CCSDS SLE specs (see #65) .

gabhijit commented 1 year ago

@xpromache : A support for parsing ALL EXCEPT is added in a branch that is mentioned in #80 . I tried to compile the specifications at https://github.com/yamcs/jsle/tree/master/src/main/asn.1 . This does not error. But there is some error during resolution of object identifiers. I am going to try to fix that as well in this PR (but might take some time).

gabhijit commented 1 year ago

@xpromache : Fix for this issue along with other fixes required to compile CCSDS SLE ASN.1 specifications is place after merging #80. You might want to review the generated structures and see if things look alright. I have quickly tried to compile these ASN.1 files and code generation looks alright.

If you think this is fine, you might want to close the issue as BER codec is being tracked separately.

xpromache commented 1 year ago

Thanks for the fix!