search

ystero-dev / scalpel

Packet Dissection and sculpting in Rust
Other
3 stars 6 forks source link

Support for dissector for ICMP Packets #29

Closed gabhijit closed 8 months ago

hgupta12 commented 8 months ago

Sir, one of the teammates is working on ICMPv6. Does it come under this issue or should we create a separate one?

gabhijit commented 8 months ago

I guess it's a better idea to create a separate one for ICMPv6 as many of the types besides the standard Echo Request/Reply are different.

hgupta12 commented 8 months ago

Sure sir, we'll make it.

gabhijit commented 8 months ago

Fixed by #38

hgupta12 commented 8 months ago

Hi @gabhijit sir, should I open a new issue for adding dissection of the data part of ICMP packets or work on other issues?

gabhijit commented 8 months ago

@hgupta12 : It's a good idea to open a new issue.