search

ystero-dev / scalpel

Packet Dissection and sculpting in Rust
Other
3 stars 6 forks source link

Fix DNS Packet Dissection and Deserialization #35

Closed aadilshabier closed 6 months ago

aadilshabier commented 6 months ago
gabhijit commented 6 months ago

@aadilshabier : There are a couple of tests failing. I have not looked at it. Let me know should I take a look.

aadilshabier commented 6 months ago

@aadilshabier : There are a couple of tests failing. I have not looked at it. Let me know should I take a look.

One of the tests, packet::tests::parse_failing packet was actually a valid packet according to Wireshark. So I ignored the test for now. The other test should pass now.

gabhijit commented 6 months ago

This is merged into the master now!! Thank you for your contribution.