search

ystero-dev / scalpel

Packet Dissection and sculpting in Rust
Other
3 stars 6 forks source link

Draft: Add support for ICMPv4 data part #47

Closed hgupta12 closed 6 months ago

hgupta12 commented 6 months ago

This PR adds ICMPv4 data dissection. Fixes #46

hgupta12 commented 6 months ago

@gabhijit sir, I have merged the IcmpData enum into the IcmpType. This does look better than my original approach. Thanks for the input!

gabhijit commented 6 months ago

This is now merged in master! Thank you for your contribution!