search

ystero-dev / scalpel

Packet Dissection and sculpting in Rust
Other
3 stars 6 forks source link

Remove lazy_static #52

Closed csking101 closed 6 months ago

csking101 commented 6 months ago

42

Removed lazy_static and implemented OnceLock

csking101 commented 6 months ago

I'd rebased already it in the force push, do I need to do it once again to squash into a single commit?

gabhijit commented 6 months ago

@csking101 : What I generally do is - if there are more than one commits - Just squash into one logical commit, so that the history looks okay. I can do it for you as well. But if you do it, I will just merge it.

csking101 commented 6 months ago

I have tried squashing it now, could you please check sir.

gabhijit commented 6 months ago

@csking101 : I have made minor edits to the git commit message and then merged that. This functionality is now available in the main branch.

Thank you for your contribution.