ystero-dev / scalpel

Packet Dissection and sculpting in Rust
Other
3 stars 6 forks source link

simplify managing the features in the crate #67

Closed gabhijit closed 4 months ago

gabhijit commented 6 months ago

Currently the crate supports three features python-bindings, logging and (soon) wasm. Some of these features are mutually incompatible and hence mutually exclusive as well. Handling these features has resulted in code with a large number of #[cfg(...)] types statement.

This can be perhaps simplified, or the feature level code is kept limited to a couple of files and some simple intuitive macros.

gabhijit commented 4 months ago

A lot of cleanup was performed by #71 .

gabhijit commented 4 months ago

Further fixes by #72 . Closing this.