ystia / yorc

Ystia Orchestrator
https://ystia.github.io
Apache License 2.0
67 stars 23 forks source link

Upgrade to a newer version of terraform #92

Open loicalbertin opened 6 years ago

loicalbertin commented 6 years ago

As: Yorc team I want to: upgrade to a newer terraform version So that: I can benefit from latest bugfixes and improvments

AC1: Check how to handle the plugin split from 1.10 https://www.hashicorp.com/blog/upcoming-provider-changes-in-terraform-0-10 AC2: This contains interesting info https://www.terraform.io/guides/running-terraform-in-automation.html AC3: Take this into account in packaging (standard packages + docker) AC4: Fix deprecations

Side note: to benefit from additional support on AWS Batch we will need to do it

schrej commented 4 years ago

While I don't think the original reason for this issue is still valid (it mentions upgrading to 0.10, but yorc uses 0.11 already) it is still valid in general. Terraform 0.12 was released early this year and we'd like to keep up to date.

We'll have to (and also should) upgrade the provider plugins as well. Unfortunately we can only test against OpenStack so we'd at least require help with testing against AWS and GCP. While we're at it, we could upgrade Consul as well, but I can also create a separate issue for that.

I've started to work on a helper that runs terraform validate during tests, so we can at least make sure that the generated infrastructure is still compatible. This would also be a good addition to the tests in general. It's not perfect yet but it works, and I'm happy to open a PR if you're interested.

https://www.terraform.io/upgrade-guides/0-12.html https://www.terraform.io/docs/extend/terraform-0.12-compatibility.html