search

ystrot / glance

Eclipse Glance
59 stars 18 forks source link

Feature Request: Add button for "Clear search history" #19

Closed sinedanat closed 12 years ago

sinedanat commented 12 years ago

Hi!

First of all thanks for all your efforts!

Feature Request:

  1. Add button for "Clear search history".
  2. Add additional setting for "Esc" to able/unable to "Close search box".

Eduard

ystrot commented 12 years ago

Hey, Eduard!

  1. You can click on the "Settings" button and select "Clear search history". Just one click more which I think OK for such a rare action.
  2. If you don't like "Esc" as a default close shortcut, you can change or disable it on the General > Keys (search by "glance") preference page.
sinedanat commented 12 years ago

Than you for advice about "Esc"!

What about the first request - I spend a lot of time searching in code. So a separate button for "Clear search history" would be very useful to clear history and disable highliting ... "Esc" may be appropriate for "Clear search history".

ystrot commented 12 years ago

Well, I don't really want to add more settings for panel, because it will make the whole interface difficult to use.

What do you think about shortcut? Will configurable shortcut work for you?

sinedanat commented 12 years ago

Great, a shortcut is appropriate for me and I would choose "Esc" for "Clear search history".

P.S.: There is a plug-in "InstaSearch" and I use a separate button for clear search history: http://s16.postimage.org/5ojpu5ijp/screen078.png

ystrot commented 12 years ago

Now you can configure "Clear history" shortcut (just take the latest build).

P.S. Thanks for mention InstaSearch. Very useful plug-in!

sinedanat commented 12 years ago

Hi, ystrot!

Thanks a lot for your efforts!

I found some issues or maybe it's only my expectations:

Issue 1:

  1. Assign key "Esc" for action "Clear History".
  2. Type a search word (phrase).
  3. Press key "Esc" for clearing history.
  4. Click in any place but not in "Code Editor".
  5. Click in any place in "Code Editor".

Result: The search word (phrase) is still present and highlight. Expected result: The search input is clear after pressing the key assigned for action "Clear History".

Issue 2:

  1. Assign key "Esc" for action "Clear History".
  2. Type a search word (phrase).
  3. Click in any place but not in the search input.

Result: The search word (phrase) is still present and highlight. The assigned key doesn't clear history. Expected result: The search input is clear after pressing the key assigned for action "Clear History" in any place not only in the search input.

That's why I wanted a separate button for clearing search history as in the plug-in "InstaSearch".

Eduard