Open cypher256 opened 8 years ago
Hi Shinji,
Thanks again for your great work on Glance! Your code looks great. There are just few things I'd like to improve:
I think the easiest way to consider these improvements would be to create a separate fork, apply all your changes as a patch, remove files we don't need in the main repo, make a single commit and provide another pull request. What do you think? Does it work for you?
Hi Yuri, Thank you for confirming my request. It''s OK, no problem. I will accept all your suggestions.
I'm an user of glance plugin, Thank you for sharing :)
Just one tip about the update site location: It would be better to have the update site also at GitHub and not at corporate and accessible place to other contributors. At GitHub it's possible to put the update site to the gh-pages branch. Just clone locally to two folders glance (master branch) and glance-gh-pages (gh-pages branch only) and commit the update-site to the second clone branch gh-pages.: Update site is then same as home-page: http://ystrot.github.io/glance/
This pull request contains the code is not related to the improvement.