search

ysugimoto / aws-lambda-image

Automatic image resize/reduce on AWS Lambda
MIT License
823 stars 219 forks source link

Fix vulnerability #179

Closed ysugimoto closed 5 years ago

ysugimoto commented 5 years ago

I've noticed security vulnerability on this package, so tried to update mainly testing related package dependencies:

And also bumped testing nodejs versions to 8.10 and 10.15, the 6.10 is no longer supported in AWS, though. See: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

Then some tests always failed with Test finished without running any assertions I'm not figured out how tests are working. Any ideas? @kdybicz @1000ch

Test logs: https://travis-ci.org/ysugimoto/aws-lambda-image/jobs/542081018

ysugimoto commented 5 years ago

@kdybicz Yes, I'm wondering why that test always fails 🤔 It seems to run assertion as same as other tests, but assertion doesn't seem to run...

So, I skip that test because network-error test isn't significantly and an AWS Lambda's network always online, I think. Is it Okey?

ysugimoto commented 5 years ago

Currently, network-error emulated test are skipping. I think it's enough for us.

kdybicz commented 5 years ago

yeah, I wanted to investigate on that, most of s3 tests doesn't seem to be executed. I was on holidays, so will try to catch up on that in the next couple of days it you're ok with that?

ysugimoto commented 5 years ago

Sure, thank you for that!

kdybicz commented 5 years ago

@ysugimoto if you're ok with my changes, branch should be ready to merge. Though I would suggest running tests locally few times on your machine before merging.

ysugimoto commented 5 years ago

@kdybicz Looks nice, thank you for fixing problem.I'll merge this PR 👍