ysugimoto / falco

falco is a VCL parser and linter decicated to Fastly
MIT License
101 stars 25 forks source link

Add extra format check for backend.share_key #331

Closed nodaguti closed 2 months ago

nodaguti commented 2 months ago

According to fastly, backend.share_key must be alphanumeric and ASCII only as in an error message shown below returned from their server.

Syntax error: `.share_key` must be alphanumeric and ASCII only
at: (input Line 48 Pos 16)
  .share_key = "nodaguti-test.storage.googleapis.com";
---------------######################################-

Thus this PR introduces new check to linter so that backend.share_key will not contain any invalid characters.

nodaguti commented 2 months ago

@ysugimoto Thank you for your review! I've fixed a test whose assertion was flipped and run `go fmt'.