search

yt-dlp / FFmpeg-Builds

FFmpeg Builds for yt-dlp
MIT License
707 stars 58 forks source link

Update lines 44 and 87 of the readme.md #28

Closed gamer191 closed 2 years ago

gamer191 commented 2 years ago

This updates line 44 of the readme, because currently it doesn't really make sense.

I didn't test either patch release-only myself, to see if it was included in ffmpeg 5.0.1, but https://github.com/yt-dlp/yt-dlp/issues/871#issuecomment-1102417981 says that the first patch wasn't included in FFmpeg 5.0.1, and the 2nd one can't possibly be included in FFmpeg 5.0.1, because it was only merged into master a few days ago. I also checked https://github.com/yt-dlp/FFmpeg-Builds/tree/master/patches/ffmpeg/release/5.0 to see which patches were included in our version 5 builds

Oh, I just realised that the git tags show which ffmpeg commits are included in the release branches. Nice :)

EDIT: this PR now also updates line 87 of the readme, for no particular reason

pukkandan commented 2 years ago

because currently it doesn't really make sense.

why do u think it doesn't make sense?

gamer191 commented 2 years ago

Because "the release" can mean a lot of different things. I guess changing the line to Patches that have been merged in FFmpeg master, but not in FFmpeg's latest release would also make sense though

pukkandan commented 2 years ago

Because "the release" can mean a lot of different things.

such as?

gamer191 commented 2 years ago

Someone could read it as "Patches that have been merged in FFmpeg master, but not in this release:"

It's probably an unnecessary change, to be honest, I just misread it the first time I read it, so I decided to make a PR to make the wording more clear