search

yt-dlp / yt-dlp

A feature-rich command-line audio/video downloader
https://discord.gg/H5MNcFW63r
The Unlicense
73.35k stars 5.81k forks source link

[extractor/cda] Fix age restriction #9939

Closed Podiumnoche closed 2 weeks ago

Podiumnoche commented 2 weeks ago

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Update to PR https://github.com/yt-dlp/yt-dlp/pull/6638

This pull request updates age confirmation to work with the new form. The code is as it was proposed by @emqi, the original poster of https://github.com/yt-dlp/yt-dlp/issues/5980.

Looks like https://github.com/Szpachlarz is not active, so I updated it according to https://github.com/yt-dlp/yt-dlp/pull/6638#discussion_r1169983986. I hope it's ready to merge, write me if anything more requires to be updated.

Fixes https://github.com/yt-dlp/yt-dlp/issues/5980

Template ### Before submitting a *pull request* make sure you have: - [X] At least skimmed through [contributing guidelines](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#developer-instructions) including [yt-dlp coding conventions](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#yt-dlp-coding-conventions) - [X] [Searched](https://github.com/yt-dlp/yt-dlp/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests - [X] Checked the code with [flake8](https://pypi.python.org/pypi/flake8) and [ran relevant tests](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#developer-instructions) ### In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under [Unlicense](http://unlicense.org/). Check all of the following options that apply: - [ ] I am the original author of this code and I am willing to release it under [Unlicense](http://unlicense.org/) - [X] I am not the original author of this code but it is in public domain or released under [Unlicense](http://unlicense.org/) (provide reliable evidence) ### What is the purpose of your *pull request*? - [X] Fix or improvement to an extractor (Make sure to add/update tests) - [ ] New extractor ([Piracy websites will not be accepted](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy)) - [ ] Core bug fix/improvement - [ ] New feature (It is strongly [recommended to open an issue first](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#adding-new-feature-or-making-overarching-changes))
Podiumnoche commented 2 weeks ago

@selfisekai could you take a look?

selfisekai commented 2 weeks ago

LGTM