search

yt-project / unyt

Handle, manipulate, and convert data with units in Python
https://unyt.readthedocs.io
BSD 3-Clause "New" or "Revised" License
364 stars 48 forks source link

Solar Mass value is 'too precise' #144

Open JBorrow opened 4 years ago

JBorrow commented 4 years ago

The solar mass equivalence value: https://github.com/yt-project/unyt/blob/711e2ebc22b59984fab1ee4dfcf745184bdb11dd/unyt/_physical_ratios.py#L22 contains too many digits. http://pdg.lbl.gov/2019/reviews/rpp2018-rev-astrophysical-constants.pdf recommends 1.98841e30 kg based on 2019 measurements.

JBorrow commented 4 years ago

Another possible issue is that the referenced pdf sheet is no longer available.

ngoldbaum commented 4 years ago

I think this if fine to be updated, personally. I think this may cause some downstream issues in yt though. @jzuhone thoughts?