Closed db434 closed 1 year ago
This seems like a good idea ! I don't have time to review in detail right now but I'll be back very shortly. In the mean time, I suggest updating this decorator's documentation to reflect the new possibility. Thanks for your work !
Thanks for taking a look.
In the mean time, I suggest updating this decorator's documentation to reflect the new possibility.
I think I've done this already - is there anywhere else that you would suggest changing?
You've updated the docstring (that's great !), but I'm talking about the narrative documentation. Namely, I'd expect some update to docs/usage.rst
Thank you for following through ! automated testing seems to have caught some syntax error in the docs. I suggest you try to run tox
locally to make sure everything is okay, because currently we need to manually approve your tests to run every time you push (this is a security measure against bad agents, it only applies to new contributors !).
Sorry for this CI spam - I've struggled to get all of the tests running locally. Hopefully this is the last time..!
I believe those tests are here. Is there anything else you're looking for?
Thanks for your patience with this!
Oh I somehow missed them, even better ! I have no further request.
Extend the
@returns
decorator so it can handle functions with multiple return values.Example:
I think I've followed everything in CONTRIBUTING, but please let me know if I've missed anything.