search

yt-project / unyt

Handle, manipulate, and convert data with units in Python
https://unyt.readthedocs.io
BSD 3-Clause "New" or "Revised" License
364 stars 48 forks source link

Include nautical miles (length) and knots (speed) #439

Closed ring-michael closed 1 year ago

ring-michael commented 1 year ago

Description

First of all a very nice package which helps a lot and I like using it in my code. However, I just ran into the issue that I needed nautical miles and knots. I guess it takes one of the developers only a few moments to include thos two units and it would be very nice if you could do that. As abbreviation for both units I would suggest NM, or nmi for nautical miles (as suggested in wikipedia: https://en.wikipedia.org/wiki/Nautical_mile)t. I am used to nm but that will get confused with nanometers and is therefore not an option. For knots I would suggest kt (https://en.wikipedia.org/wiki/Knot_(unit)).

neutrinoceros commented 1 year ago

You'd be surprised how little time we actually have; none of us is getting paid for maintaining unyt.

A pull request adding these units would be most welcome, however.

ring-michael commented 1 year ago

Hei, many thanks for the quick response. I was somehow fearing that you won't have the time to do so. We will have a look into the software than and see what we can come up with to send a pull request.

Cheers

chrishavlin commented 1 year ago

In case you missed it in the docs, you can also create your own units -- see the section on User-Defined Units. So depending on what you need nautical miles and knots for, might be simplest to just define those units dynamically when you need them rather rather than adding them to the base unyt package (I'm not trying to dissuade you from submitting a PR here! just wanted to make sure you were aware of this option).

neutrinoceros commented 1 year ago

Thanks Chris ! I really should have mentioned it. Next time I'm take my coffee before I answer to feature requests ;)

jzuhone commented 1 year ago

This is mysterious--I for some reason thought we already had these units. @ring-michael I can add this--you are correct that this is a pretty straightforward add and it's a good idea. I already was thinking about some other units that were missing and needed adding, so I'll do it today.

jzuhone commented 1 year ago

@ring-michael see #441