search

yt-project / unyt

Handle, manipulate, and convert data with units in Python
https://unyt.readthedocs.io
BSD 3-Clause "New" or "Revised" License
358 stars 46 forks source link

TST: avoid installing mpmath pre-releases in bleeding edge CI #490

Closed neutrinoceros closed 3 months ago

neutrinoceros commented 4 months ago

Turns out #489 wasn't sufficient to fix bleeding-edge CI. Example log

So I dug a little deeper and what's happening is that mpmath (which we depend on indirectly via sympy) is preparing a new release, currently in alpha (1.4.0a0), which breaks sympy. It's all being discussed upstream by their respective maintainers (see https://github.com/sympy/sympy/issues/26268 and https://github.com/mpmath/mpmath/issues/704), so there isn't much we can do about it on our side but hope for the best outcome.

While we still want to test against sympy pre-releases, we should probably not care about testing with pre-releases of its dependencies (they are doing it already). The way to do that with pip is to install sympy normally then upgrade just it with --upgrade --no-deps --pre.

neutrinoceros commented 4 months ago

@jzuhone for review With the upcoming numpy 2.0 release, I'd like to get bleeding-edge CI relevant again :)

neutrinoceros commented 3 months ago

Closing/reopening to refresh CI and see if everything is still okay after this patch.

neutrinoceros commented 3 months ago

In more than one way, it's not. Let me address the new problems in follow up PRs.

neutrinoceros commented 3 months ago

turns out a single other patch suffices: https://github.com/yt-project/unyt/pull/492