search

yt-project / widgyts

Widgets for yt
https://widgyts.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 10 forks source link

Convert to Typescript #53

Closed matthewturk closed 3 years ago

matthewturk commented 4 years ago

I'm still learning typescript, but this is my WIP of a conversion to it.

I've also gotten rid of the notebook plugin, and just have the lab plugin. Right now it's very vanilla, straightforward, nothing fancy.

Also it doesn't work yet.

matthewturk commented 4 years ago

What I would like to propose is that this be reviewed as a proof-of-concept and for broad correctness, and then I will update the documentation before it is accepted.

munkm commented 3 years ago

We've decided to merge this for now and refine it (and update docs) in separate PRs. Thanks for doing this conversion @matthewturk !!

matthewturk commented 3 years ago

I've updated the tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (ddf14fd) into master (9f44e67) will increase coverage by 0.90%. The diff coverage is 93.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   74.09%   75.00%   +0.90%     
==========================================
  Files           6        5       -1     
  Lines         359      372      +13     
==========================================
+ Hits          266      279      +13     
  Misses         93       93
Impacted Files Coverage Δ
widgyts/image_canvas.py 86.20% <89.74%> (+3.44%) :arrow_up:
widgyts/_version.py 100.00% <100.00%> (ø)
widgyts/colormaps.py 100.00% <100.00%> (ø)
widgyts/tests/test_widgyts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f44e67...ddf14fd. Read the comment docs.

matthewturk commented 3 years ago

@munkm I think this should be ready to go in, so I can get to work on a subsequent PR that updates the docs.