Closed matthewturk closed 4 years ago
I don't understand the travis errors, which seem to be related to pytest.
I should also note, this updates to work with current yt HEAD.
Many of my thoughts here are design questions and not totally necessary to resolve for this PR.
So I think I resolved most of the comments -- some might take longer to do and may be better for other PRs.
Merging #54 into master will decrease coverage by
15.62%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #54 +/- ##
===========================================
- Coverage 89.33% 73.71% -15.63%
===========================================
Files 6 7 +1
Lines 225 369 +144
===========================================
+ Hits 201 272 +71
- Misses 24 97 +73
Impacted Files | Coverage Δ | |
---|---|---|
widgyts/dataset_viewer.py | 41.60% <41.60%> (ø) |
|
widgyts/__init__.py | 60.00% <100.00%> (+4.44%) |
:arrow_up: |
widgyts/image_canvas.py | 82.75% <100.00%> (+0.45%) |
:arrow_up: |
widgyts/tests/test_widgyts.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5720ef4...a3dcba8. Read the comment docs.
Ok! Do you want to add tests to this PR or should we open an issue for them?
I'll try to add them, but they'll just be "does this instantiate."
On Mon, Sep 21, 2020 at 2:35 PM Madicken Munk notifications@github.com wrote:
Ok! Do you want to add tests to this PR or should we open an issue for them?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/data-exp-lab/widgyts/pull/54#issuecomment-696326955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVXO6L4SB2WJVGPL3TCTTSG6TGLANCNFSM4OV6XGRA .
Nothing much yet, but thinking about how to start up a dataset viewer, and then ultimately link it with the canvas.