Closed matthewturk closed 4 years ago
The real issue seems to be the version of yt we are installing.
One option identified here is to use this in our install_requires
:
'ExampleRepo @ git+ssh://git@github.com/example_organization/ExampleRepo.git#egg=ExampleRepo-0.1'
until there is a new release of yt.
can't we test for yt < 3.6 until 3.6.1 comes out?
I genuinely don't know.
On Fri, Sep 18, 2020 at 2:45 PM Madicken Munk notifications@github.com wrote:
can't we test for yt < 3.6 until 3.6.1 comes out?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/data-exp-lab/widgyts/pull/56#issuecomment-695052778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVXO5TQ2VVMMPJ4Z5GYMLSGO2EVANCNFSM4RSNA4UA .
Merging #56 into master will increase coverage by
0.09%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 89.23% 89.33% +0.09%
==========================================
Files 6 6
Lines 223 225 +2
==========================================
+ Hits 199 201 +2
Misses 24 24
Impacted Files | Coverage Δ | |
---|---|---|
widgyts/image_canvas.py | 82.30% <0.00%> (+0.31%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b62e3c2...5a654ad. Read the comment docs.
ok i pinned matplotlib for our tests instead. We can unpin later.
Python 3.5 doesn't work with current pytest-cov.