search

yt-project / widgyts

Widgets for yt
https://widgyts.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 10 forks source link

Add a button that records the current camera positions of the user to a listbox for future retrieval #77

Closed niruochengfeng05 closed 2 years ago

niruochengfeng05 commented 2 years ago

This is draft commit, of which a button is added to the interface. It enables users to record the current camera positions and store those positions in a list box for future retrieval.

matthewturk commented 2 years ago

@coconutcc Can you run the git precommit hooks, like you did last time, before you update your PR?

matthewturk commented 2 years ago

Hi @coconutcc , you will need to revert your previous commit. It looks like you added the entire example dataset, and then committed.

You can reduce the likelihood of doing this by always inspecting what you are committing before you do so. For instance, I would recommend never doing git add . and instead always either adding file by file, using git add -p or git add -u if you are not adding new files.

Please revert the commit.

matthewturk commented 2 years ago

This is looking good!

The next step, and possibly the last thing for the PR to be accepted, is to have the on-click handler change the camera position. That way, when you click, it will update the position so you can browse all the previous key frames.

matthewturk commented 2 years ago

So I think that this looks good, but I remember you saying it doesn't quite function properly. I'm giving my sign-off on the code without having run it, but I'll run it next to see if I can see what is causing the issues.

matthewturk commented 2 years ago

I have looked into it, and I think that this is as good as we can get for right now. I'd like you to mark this as non-draft and remove wip from the title and we'll merge.