yt-project / yt

Main yt repository
http://yt-project.org
Other
454 stars 272 forks source link

Re-enable healpix interface in yt after resolving licensing concerns #1048

Open yt-fido opened 8 years ago

yt-fido commented 8 years ago

Originally reported by: Bili Dong (Bitbucket: qobilidop, GitHub: qobilidop)


In grid_traversal.pyx the following 10 functions will raise a NotImplementedError no matter what:

Based on the discussion in Issue #1047, this is because their common dependency healpix_interface was removed for licensing concerns. I've only seen those functions being used in the module /yt/visualization/volume_rendering/camera.py. So I guess either those functions should be fixed, or camera.py should be rewritten.

If my understanding is correct, the module yt/utilities/lib/healpix_interface.pxd should also be removed, right?


yt-fido commented 8 years ago

Original comment by Nathan Goldbaum (Bitbucket: ngoldbaum, GitHub: ngoldbaum):


Reimplimenting the healpix functionality constitutes a new feature and shouldn't block 3.3.

qobilidop commented 6 years ago

I'm starting to work on this. I'm not very familiar with the volume rendering infrastructure. I notice that there're camera.py and old_camera.py. My understanding is that old_camera.py is deprecated in favor of camera.py, and what used to be old_camera.py/HEALpixCamera, should now be reimplemented as lens.py/HEALpixLens, am I correct? @ngoldbaum @MatthewTurk

ngoldbaum commented 6 years ago

Yup, that’s right.