Closed yut23 closed 1 month ago
I misunderstood the problem that @neutrinoceros raised in his comment. As noted in conftest.py, we explicitly ignore this class of warnings during tests, and they're ignored by default during normal usage. I'm leaving the PR open, as closing the files is probably a good idea anyways.
Interesting. I didn't mean to suggest that the problem existed on main, but maybe it does, and in that case it cannot be a blocker to #4845. Your PR clearly shows that's indeed the current state so I suggest we keep this open too.
Bug report
Bug summary
open()
is used several times in the boxlib frontend without closing the files, triggering aResourceWarning
when the files go out of scope. Originally noticed by @neutrinoceros in https://github.com/yt-project/yt/issues/4845#issuecomment-2029735171.Code for reproduction
Standalone reproducer using the
ParticleCavity
dataset:Actual outcome
Expected outcome
No warnings.
Version Information