I am now almost sure that the comment I wrote for this filter (circa 2021) was ill-informed and misleading. Astropy's wheels in fact were already being built in a forward-compatible way with oldest-supported-numpy at the time and continue to be (now using the more modern mechanism introduced in numpy 1.25). I suspect the real reason why we were seeing this warning was that we installed numpy from conda and then astropy from PyPI, which we haven't been doing since https://github.com/yt-project/yt/pull/4624
PR Summary
I am now almost sure that the comment I wrote for this filter (circa 2021) was ill-informed and misleading. Astropy's wheels in fact were already being built in a forward-compatible way with
oldest-supported-numpy
at the time and continue to be (now using the more modern mechanism introduced in numpy 1.25). I suspect the real reason why we were seeing this warning was that we installed numpy from conda and then astropy from PyPI, which we haven't been doing since https://github.com/yt-project/yt/pull/4624