search

yt-project / yt

Main yt repository
http://yt-project.org
Other
454 stars 272 forks source link

DOC: replace boxlib with amrex references in the docs #4925

Closed chrishavlin closed 3 weeks ago

chrishavlin commented 3 weeks ago

Was building the docs locally and noticed a few spots that should be updated to reflect #4845

neutrinoceros commented 3 weeks ago

This is inevitably going to hit https://github.com/yt-project/yt/issues/4924, but it's also a very timely opportunity to fix it 🤗 Can you add ipykernel to doc deps ?

chrishavlin commented 3 weeks ago

sure! will add it here

chrishavlin commented 3 weeks ago

just added, didn't pin it to a version though. if the docs build succeeds I can pin it to whatever version it resolves to.

chrishavlin commented 3 weeks ago

docs build isn't done, but looks like it's chugging along just fine. I'm going to push up one more batch to fix the small typo that @neutrinoceros caught and pin ipykernel to ipykernel>=6.29.4 (which is what the version the current docs build is running with).

EDIT: got distracted and hte build finished successfully in the mean time! just pushed the pinned version