search

yt-project / yt

Main yt repository
http://yt-project.org
Other
465 stars 276 forks source link

Add support for Enzo-E simulations with 0 ghost zones #4932

Closed mabruzzo closed 2 months ago

mabruzzo commented 3 months ago

PR Summary

The primary purpose of this PR was to add support for Enzo-E simulations with 0 ghost zones.

While I was here, I added support for Enzo-E simulations where the x, y, and z axes have different numbers of ghost zones (this is a feature that Enzo-E supports, but it's not really used). I also added some explanatory comments.

neutrinoceros commented 3 months ago

Thanks @mabruzzo ! I'll review this tomorrow but I just wanted to point out that you will likely hit a couple unrelated bugs that are solved in #4930 so don't scratch your head too much over failures for now :)

mabruzzo commented 3 months ago

Thanks @mabruzzo ! I'll review this tomorrow but I just wanted to point out that you will likely hit a couple unrelated bugs that are solved in #4930 so don't scratch your head too much over failures for now :)

Gotcha.

FYI this is currently built off of a slightly older point in the main branch. This was mainly for convenience (I was a really hard time setting up yt off of the HEAD of the main-branch. My issues are probably user-error. (I recently switched to a new machine and started using conda for the first time in years). I'm happy to fast-forward this whenever.

neutrinoceros commented 3 months ago

FYI this is currently built off of a slightly older point in the main branch.

as long as there are no conflicts (which there aren't), this shouldn't matter :)

neutrinoceros commented 3 months ago

@yt-fido Test this please

neutrinoceros commented 2 months ago

The typing error is unrelated and already fixed on main, so let’s get this in. Thanks again for your patience !