AMRVAC: variable He abundance

yt-project / yt

Main yt repository

http://yt-project.org

Other

454 stars 272 forks source link

AMRVAC: variable He abundance #4937

Closed jordidj closed 4 days ago

jordidj commented 5 days ago

PR Summary

Removed hardcoded He abundance for AMRVACDataset unit calculation. Instead, it is now read from the AMRVAC parfile.

PR Checklist

[ ] New features are documented, with docstrings and narrative docs
[ ] Adds a test for any bugs fixed. Adds tests for new features.

welcome[bot] commented 5 days ago

Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution!

neutrinoceros commented 4 days ago

please make sure pre-commit linting stays green. Right now it looks like your latest push introduced a SyntaxError

welcome[bot] commented 4 days ago

Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! :fireworks:

chrishavlin commented 4 days ago

Thanks for the PR @jordidj !