search

yt-project / yt

Main yt repository
http://yt-project.org
Other
465 stars 276 forks source link

Fix memory leakage #4945

Closed cindytsai closed 2 months ago

cindytsai commented 2 months ago

PR Summary

This is a bug that causes memory leakage in projections.

It forgot to free vorig when returning inside the if block. Since vorig won't be used inside that if block anyway, it should be moved under the if block.

welcome[bot] commented 2 months ago

Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution!

welcome[bot] commented 2 months ago

Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! :fireworks:

matthewturk commented 2 months ago

I'd like to just add here that @cindytsai was really diligent in tracking this down, and really put a lot of effort into finding it. Thank you, @cindytsai !