BUG: fix ds.all_data() for spherical AMReX datasets

yt-project / yt

Main yt repository

http://yt-project.org

Other

469 stars 280 forks source link

BUG: fix ds.all_data() for spherical AMReX datasets #5025

Open yut23 opened 1 month ago

yut23 commented 1 month ago

PR Summary

ds.index.level_dds was being overwritten in _parse_index(), which breaks the all_data() region selector. This PR instead updates domain_right_edge in _parse_header_file(), like we do for cylindrical datasets.

PR Checklist

[ ] New features are documented, with docstrings and narrative docs
[x] Adds a test for any bugs fixed. Adds tests for new features.

neutrinoceros commented 1 month ago

For future reference, the datasets are registered at https://github.com/yt-project/website/pull/129

neutrinoceros commented 1 month ago

very nice. Let me add this to the 4.4.0 milestone in case we can squeeze it in before the release is unblocked.