yt-project / yt

Main yt repository
http://yt-project.org
Other
469 stars 280 forks source link

pin xradar<0.8.0 in tests #5042

Closed chrishavlin closed 2 weeks ago

chrishavlin commented 2 weeks ago

This is a temporary fix for #5041 on yt's side that should get tests passing but will need to be updated when a fix on the the arm-pyart side is released (at which point we could pin a min version for arm-pyart for the tests).

chrishavlin commented 2 weeks ago

just to summarize the confusing dependency resolution (and why I just pinnned xradar here):

So effectively arm-pyart currently has both a hard dependency on xradar < 0.8.0 and xarray-datatree and just pinning xradar < 0.8.0 is sufficient for yt's tests.

Moving forward, the simplest thing to do will be to replace the change in this PR with a test requirement on arm-pyart >= 1.16.2 after it is released (and assuming it contains a fix).

neutrinoceros commented 2 weeks ago

Thanks a lot for the write up, I was really confused by this situation.