Install script gets the wrong version of Rockstar.

[yt-fido]

Originally reported by: Britton Smith (Bitbucket: brittonsmith, GitHub: brittonsmith)

---

@MatthewTurk, would it be easiest to pull the appropriate changes into your hg repo that the install script is using now?

---

• Bitbucket: https://bitbucket.org/yt_analysis/yt/issue/870

[yt-fido]

Original comment by chummels (Bitbucket: chummels, GitHub: chummels):

---

Removing milestone: 3.0 (automated comment)

[yt-fido]

Original comment by Matt Turk (Bitbucket: MatthewTurk, GitHub: MatthewTurk):

---

Fixed

[yt-fido]

Original comment by Sam Skillman (Bitbucket: samskillman, GitHub: samskillman):

---

Ok, new PR up : https://bitbucket.org/MatthewTurk/rockstar/pull-request/2/more-updates-to-fix-the-yt-rockstar/diff . Hopefully more successful this time!

[yt-fido]

Original comment by Sam Skillman (Bitbucket: samskillman, GitHub: samskillman):

---

Shoot, sorry, I tested mine above and it must have only re-compiled rockstar_interface and not the groupies. I'll fix it over here and report back asap.

[yt-fido]

Original comment by Britton Smith (Bitbucket: brittonsmith, GitHub: brittonsmith):

---

I get past the build of rockstar, but now I get the following when building yt:

#!bash

yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c:2888:5: error: use of undeclared identifier 'EXACT_LL_CALC'
    EXACT_LL_CALC = 1.0;
    ^
3 warnings and 1 error generated.
In file included from yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c:314:
In file included from /Users/britton/Desktop/yt-x86_64/lib/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h:15:
In file included from /Users/britton/Desktop/yt-x86_64/lib/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h:17:
In file included from /Users/britton/Desktop/yt-x86_64/lib/python2.7/site-packages/numpy/core/include/numpy/ndarraytypes.h:1728:
/Users/britton/Desktop/yt-x86_64/lib/python2.7/site-packages/numpy/core/include/numpy/npy_deprecated_api.h:11:2: warning: "Using deprecated NumPy API, disable it by #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
#warning "Using deprecated NumPy API, disable it by #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"
 ^
yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c:1427:1: warning: declaration does not declare anything [-Wmissing-declarations]
__pyx_t_2yt_16analysis_modules_12halo_finding_8rockstar_17rockstar_groupies_haloflat;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c:1429:1: warning: declaration does not declare anything [-Wmissing-declarations]
__pyx_t_2yt_16analysis_modules_12halo_finding_8rockstar_17rockstar_groupies_haloflat;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c:2888:5: error: use of undeclared identifier 'EXACT_LL_CALC'
    EXACT_LL_CALC = 1.0;
    ^
3 warnings and 1 error generated.
error: Command "/usr/bin/clang -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -mmacosx-version-min=10.7 -DTHREADSAFE= -I/Users/britton/Desktop/yt-x86_64/src/rockstar -I/Users/britton/Desktop/yt-x86_64/src/rockstar/io -I/Users/britton/Desktop/yt-x86_64/src/rockstar/util -I/Users/britton/Desktop/yt-x86_64/lib/python2.7/site-packages/numpy/core/include -I/Users/britton/Desktop/yt-x86_64/include/python2.7 -c yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.c -o build/temp.macosx-10.4-x86_64-2.7/yt/analysis_modules/halo_finding/rockstar/rockstar_groupies.o" failed with exit status 1

[yt-fido]

Original comment by Matt Turk (Bitbucket: MatthewTurk, GitHub: MatthewTurk):

---

PR accepted -- try again?

[yt-fido]

Original comment by Matt Turk (Bitbucket: MatthewTurk, GitHub: MatthewTurk):

---

Sam has a PR that fixes this. I'll update once I accept it.

[yt-fido]

Original comment by Britton Smith (Bitbucket: brittonsmith, GitHub: brittonsmith):

---

I just tried installing yt from the install script with Rockstar and got the following error:

#!bash

fatal: Not a git repository (or any of the parent directories): .git
gcc -m64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_BSD_SOURCE -D_POSIX_SOURCE -D_POSIX_C_SOURCE=200809L -D_SVID_SOURCE -D_DARWIN_C_SOURCE -Wall -fno-math-errno -fPIC `pkg-config libSDF-1.0 --cflags` -shared rockstar.c check_syscalls.c fof.c groupies.c subhalo_metric.c potential.c nfw.c jacobi.c fun_times.c interleaving.c universe_time.c distance.c config_vars.c config.c bounds.c inthash.c io/read_config.c client.c server.c merger.c version.c inet/socket.c inet/rsocket.c inet/address.c io/meta_io.c io/io_internal.c io/io_ascii.c io/stringparse.c io/io_gadget.c io/io_generic.c io/io_art.c io/io_tipsy.c io/io_bgc2.c io/io_sdf.c io/io_util.c -o librockstar.so -lm -g -O3 -std=c99 `pkg-config libSDF-1.0 --libs`
Package libSDF-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libSDF-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libSDF-1.0' found
Package libSDF-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libSDF-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libSDF-1.0' found
io/io_sdf.c:16:17: error: SDF.h: No such file or directory
io/io_sdf.c: In function ‘sdf_check’:
io/io_sdf.c:51: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c:51: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c: In function ‘sdf_renumber_particles’:
io/io_sdf.c:63: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c:63: warning: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘int64_t’
io/io_sdf.c:63: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c:63: warning: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘int64_t’
io/io_sdf.c: In function ‘load_particles_sdf’:
io/io_sdf.c:86: error: ‘SDF’ undeclared (first use in this function)
io/io_sdf.c:86: error: (Each undeclared identifier is reported only once
io/io_sdf.c:86: error: for each function it appears in.)
io/io_sdf.c:86: error: ‘sdfp’ undeclared (first use in this function)
io/io_sdf.c:107: warning: implicit declaration of function ‘SDFopen’
io/io_sdf.c:108: error: ‘SDFerrstring’ undeclared (first use in this function)
io/io_sdf.c:112: warning: implicit declaration of function ‘SDFgetint’
io/io_sdf.c:118: warning: implicit declaration of function ‘SDFgetdoubleOrDie’
io/io_sdf.c:125: warning: implicit declaration of function ‘SDFgetdouble’
io/io_sdf.c:151: warning: implicit declaration of function ‘SDFgetint64’
io/io_sdf.c:154: warning: implicit declaration of function ‘SDFhasname’
io/io_sdf.c:196: warning: implicit declaration of function ‘SDFnrecs’
io/io_sdf.c:199: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c:199: warning: format ‘%ld’ expects type ‘long int’, but argument 3 has type ‘int64_t’
io/io_sdf.c:209: warning: implicit declaration of function ‘SDFseekrdvecsarr’
io/io_sdf.c:220: warning: format ‘%ld’ expects type ‘long int’, but argument 10 has type ‘int64_t’
io/io_sdf.c:220: warning: format ‘%ld’ expects type ‘long int’, but argument 10 has type ‘int64_t’
io/io_sdf.c:263: warning: implicit declaration of function ‘SDFclose’
make: *** [lib] Error 1