search

yt-project / yt_astro_analysis

yt astrophysical analysis modules
Other
21 stars 21 forks source link

MNT: add workflow to automate wheels build #109

Closed neutrinoceros closed 2 years ago

neutrinoceros commented 2 years ago

Fix #107 I've run the workflow successfully on my fork here https://github.com/neutrinoceros/yt_astro_analysis/actions/runs/1526300758

neutrinoceros commented 2 years ago

Note: I have manually validated macOS wheels for

neutrinoceros commented 2 years ago

For some reason it seems that I can't install Python 3.7 macOS wheels locally. This is the only supported version for which I'm encountering this issue.

ERROR: yt_astro_analysis-1.1.0.dev2-cp37-cp37m-macosx_10_9_x86_64.whl is not a supported wheel on this platform.

I also have the exact same problem with latest wheels built for yt itself.

edit: in fact it looks like we never released a cp37-cp37 wheel for yt itself on PyPI, it was always cp37-cp37m (same Python version different ABI), so actually what we're getting here seems to be perfectly in line with yt.

brittonsmith commented 2 years ago

edit: in fact it looks like we never released a cp37-cp37 wheel for yt itself on PyPI, it was always cp37-cp37m (same Python version different ABI), so actually what we're getting here seems to be perfectly in line with yt.

Ok, then I'm inclined to not worry about it. I don't see any reason to go out of our way making wheels for versions without yt wheels. If the user can install yt without the wheel for this Python version, then they should be able to install yt-astro as well.

neutrinoceros commented 2 years ago

It's even less of a problem than you might think. I forgot to report it here but down the rabbit hole I found some explanation for this in CPython's documentation:

https://docs.python.org/3/library/sys.html?highlight=abi#sys.abiflags

so it's really just a known upstream change that we don't need to care about, which happened with Python 3.8