yt-project / yt_astro_analysis

yt astrophysical analysis modules

Other

21 stars 21 forks source link

BUG: several small bugs in doc/source/PPVCube.ipynb #227

Open neutrinoceros opened 11 months ago

neutrinoceros commented 11 months ago

Trying to run this notebook showed that it's not currently compatible with modern yt or astropy

225 and #226 resolve the first couple issues, but there are more:

ambiguous field errors (yt 4.1+)
dirty outputs (deprecation warnings from #225 and #226 need to be cleaned up)

neutrinoceros commented 11 months ago

I fixed a couple more issues in #228 but it's not over. I think that remaining errors (YTAmbiguousDataType, AttributeError, incorrect unit parsing ...) would benefit from someone else's look (@jzuhone ? @brittonsmith ? @cphyc ?)

jzuhone commented 11 months ago

@neutrinoceros #187 is probably relevant (and should be finished and merged, tbh) but I haven't had a chance to check yet

neutrinoceros commented 11 months ago

Seems fair. If I get no complaints about #228 I intend to merge it a couple days, and I'll assume the rest of the issues will be fixed later.

jzuhone commented 11 months ago

@neutrinoceros FWIW I'm the one who developed PPVCube and the only one who knows anything about it :) so you're waiting on me for #228, I'll try today

neutrinoceros commented 11 months ago

Sounds good.