search

yt-project / yt_idv

Interactive volume rendering for yt
Other
9 stars 6 forks source link

Add a first pass at rescaling the vertices #1

Closed matthewturk closed 1 year ago

matthewturk commented 3 years ago

This adds a check for the extent of the block edges in the block data, and then rescales and translates based on that.

matthewturk commented 3 years ago

So as of right now, the rescaling and matrices seem to work -- but! There is an issue in the ray tracing section I am attempting to debug. When we do anything that provides a matrix that is not explicitly unitary, it results in some nasty artifacts that suggest something more sinister is going on. I will return to this.

chrishavlin commented 1 year ago

@matthewturk Is this superseded by #79 at this point? I've been bumping it along in the milestone lists cause I wasn't certain what you had planned for it :)

matthewturk commented 1 year ago

I think we can close it

On Fri, Jun 16, 2023 at 1:43 PM Chris Havlin @.***> wrote:

@matthewturk https://github.com/matthewturk Is this superseded by #79 https://github.com/yt-project/yt_idv/pull/79 at this point? I've been bumping it along in the milestone lists cause I wasn't certain what you had planned for it :)

— Reply to this email directly, view it on GitHub https://github.com/yt-project/yt_idv/pull/1#issuecomment-1595133550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVXO77S4BASC3LMTULBNLXLSSM5ANCNFSM4T77JGWQ . You are receiving this because you were mentioned.Message ID: @.***>