search

yt-project / yt_idv

Interactive volume rendering for yt
Other
9 stars 6 forks source link

manifest fix and another patch release #36

Closed chrishavlin closed 3 years ago

chrishavlin commented 3 years ago

This takes care of the remaining setup issue (the pyx files were not included in the sdist tarball). This bumps the version patch number again, I'll trigger another release after this gets merged.

Xarthisius commented 3 years ago

What about the shaders?

missing from sdist:
  .bumpversion.cfg
  .editorconfig
  .pre-commit-config.yaml
  .readthedocs.yml
  AUTHORS.md
  CONTRIBUTING.md
  HISTORY.md
  Makefile
  docs/requirements.txt
  examples
  examples/amr_offscreen.py
  examples/amr_osmesa.py
  examples/amr_volume_rendering.py
  examples/grid_positions.py
  examples/hires_galaxy.py
  examples/idv_widget.ipynb
  examples/mesh_render.py
  examples/octree_volume_rendering.py
  examples/particle_rendering.py
  examples/sph_rendering.py
  tox.ini
  yt_idv/shaders/apply_colormap.frag.glsl
  yt_idv/shaders/block_outline.frag.glsl
  yt_idv/shaders/constant.frag.glsl
  yt_idv/shaders/default.vert.glsl
  yt_idv/shaders/draw_colormap.frag.glsl
  yt_idv/shaders/draw_lines.frag.glsl
  yt_idv/shaders/draw_lines.vert.glsl
  yt_idv/shaders/expand_1d.frag.glsl
  yt_idv/shaders/field_value.frag.glsl
  yt_idv/shaders/grid_expand.geom.glsl
  yt_idv/shaders/grid_position.vert.glsl
  yt_idv/shaders/header.inc.glsl
  yt_idv/shaders/known_uniforms.inc.glsl
  yt_idv/shaders/max_intensity.frag.glsl
  yt_idv/shaders/mesh.frag.glsl
  yt_idv/shaders/mesh.vert.glsl
  yt_idv/shaders/noop.frag.glsl
  yt_idv/shaders/octree_position.vert.glsl
  yt_idv/shaders/particle.vert.glsl
  yt_idv/shaders/particle_expand.geom.glsl
  yt_idv/shaders/passthrough.frag.glsl
  yt_idv/shaders/passthrough.vert.glsl
  yt_idv/shaders/projection.frag.glsl
  yt_idv/shaders/ray_tracing.frag.glsl
  yt_idv/shaders/shaderlist.yaml
  yt_idv/shaders/sph_kernel.frag.glsl
  yt_idv/shaders/textoverlay.frag.glsl
  yt_idv/shaders/textoverlay.vert.glsl
  yt_idv/shaders/transfer_function.frag.glsl
suggested MANIFEST.in rules:
  include *.md
  include *.yaml
  include *.yml
  include .bumpversion.cfg
  include Makefile
  include tox.ini
  recursive-include docs *.txt
  recursive-include examples *.ipynb
  recursive-include examples *.py
  recursive-include yt_idv *.glsl
  recursive-include yt_idv *.yaml
chrishavlin commented 3 years ago

oh! goooooood catch. and having those missing wouldn't error on import yt_idv... which is what I was using to check. Thanks for catching that!

Xarthisius commented 3 years ago

FTR I've used check-manifest

chrishavlin commented 3 years ago

FTR I've used check-manifest

very useful to know, thank you!

The latest push includes the fix suggested in #37 , though it looks like I need to tell isort to ignore that line. So one more push coming...

chrishavlin commented 3 years ago

Now that tests passed, this should be good to go! I did some more thorough local testing including running examples with the local build (not just importing...) and everything worked.

chrishavlin commented 3 years ago

ah, hang on, don't merge yet -- I should adjust the cython include lines to not be global-includes as they're picking up files in .tox. Will switch those to recursive includes.

chrishavlin commented 3 years ago

ok, good to go after tests pass!