Adding temp PR for spherical rendering

sochowski commented 2 years ago

This is a temporary PR to help figure out why the colormap isn't being correctly applied with spherical coordinates

chrishavlin commented 2 years ago

note: I added this to the 0.3.0 milestone, but that's mostly as a reminder to me and @matthewturk to get back into this and figure out what needs to happen to get this in! Likely we'll move it back a milestone, but I don't want this work to get lost!

chrishavlin commented 1 year ago

latest batch:

spherical-to-cartesian fixes: added some uniforms so that we can pass down the axis index order for spherical datasets to ensure we're using the right variables for polar/azimuthal angles.
passes along variables in spherical coordinates as much as possible in the shader pipeline. adds comments to note which variables will always be in cartesian coordinates.
merged with main

pretty sure it's working as expected now... still need to add some fragment-intersection tests and ray tracing sampling, but the underlying geometry shaders seem to be working now. Attaching an image from the current version of examples/amr_spherical_volume_rendering.py Screenshot from 2022-12-02 10-47-39

chrishavlin commented 1 year ago

weird, not sure why the PR was closed there...

chrishavlin commented 1 year ago

hey @sochowski not sure what happened there... maybe cause I pushed to your main yt_idv branch? I think I may need to open another PR... I'll tag you in it so you get credit for it.

chrishavlin commented 1 year ago

ok, well the new PR preserved the commit history, going to leave this one closed. No need to do anything, @sochowski :)

yt-project / yt_idv

Adding temp PR for spherical rendering #42