search

yt-project / yt_idv

Interactive volume rendering for yt
Other
8 stars 6 forks source link

Set unitary scale for the block collection #79

Closed matthewturk closed 1 year ago

matthewturk commented 1 year ago

We utilize unitary scaling almost everywhere when setting positions; this is even built into the YTPositionTrait object. However, we don't utilize this in the setting of the left and right edges of the objects, because our PartitionedGrid objects don't have units associated with their attributes.

One side effect of this is that when loading a dataset where the unitary scale is wildly different from the code_length scale, our camera position is strange and set in the wrong absolute coordinate values.

matthewturk commented 1 year ago

I have not convinced myself this is the correct approach, rather than utilizing units everywhere else. The issue I see is that we are still inputting some things in code_length, like when adding grid outlines (not block outlines) so I want to double check.

chrishavlin commented 1 year ago

oh hey, this might fix #45

chrishavlin commented 1 year ago

I have confirmed that as it is, this PR does indeed Close #45 !

matthewturk commented 1 year ago

Before this gets merged we need to fix the grid display