ytai / ioio

Software, firmware and hardware of the IOIO - I/O for Android
Apache License 2.0
746 stars 355 forks source link

Release on GitHub #193

Closed hannesa2 closed 3 years ago

hannesa2 commented 3 years ago

This will upload libaries artifacts to github release like https://github.com/hannesa2/ioio/releases/tag/6.0.0-beta4.r20

hannesa2 commented 3 years ago

Now I wait for secret GITHUBTOKEN like this

image

topherbuckley commented 3 years ago

Is there a reason this is not handled by jitpack? Seems like duplicate generation of aar files no?

hannesa2 commented 3 years ago

Is there a reason this is not handled by jitpack? Seems like duplicate generation of aar files no?

Jitpack has currently only Android aar , for PC the *.jar files are now on github, it's a kind of replace of directory releases and move stuff to github https://github.com/ytai/ioio/releases with artifacts

topherbuckley commented 3 years ago

Jitpack has currently only Android aar

Is that true? The doc link I sent seems to indicate you can also generate JAR files and points to this file as an example.

It'd be nice if they were all in the same place if possible, but I agree that github releases make more sense than a releases folder.

hannesa2 commented 3 years ago

Jitpack has currently only Android aar

Is that true? The doc link I sent seems to indicate you can also generate JAR files and points to this file as an example.

It'd be nice if they were all in the same place if possible, but I agree that github releases make more sense than a releases folder.

Now https://jitpack.io/#ytai/ioio/6.0.0.beta6 has *.jar as well

image
topherbuckley commented 3 years ago

Nice job!

One issue I see with these still though is there doesn't appear to be any release notes, or anything to differentiate between releases.

Is there a way to add release notes to these detailing what has been updated? It would likely take a bit more work to write these nicely for all beta releases, but at the very least, could we maybe just bundle all the master branch commit messages between the release and the previous release? For example I don't know if the newer releases are based on the AppCompat libraries or not without downloading the whole set and testing whether it breaks my project or not.

topherbuckley commented 3 years ago

Never mind. I had no idea github could do a diff on them directly. Not need for release notes if that is the case.