view composer name & path

ytake / Laravel.Smarty

smarty template engine for laravel

MIT License

85 stars 24 forks source link

view composer name & path #45

Closed ytake closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+1.3%) to 100.0% when pulling 9ef35bfe5b2eebcdbf9b120a120090608e725f7b on feature-issue44 into 4dd647b6287ef67e72742c3c7d4432463cd88171 on master.

JayBizzle commented 7 years ago

Just one thing I have noticed after testing this out quickly.

If you have an include that uses a variable, the output will be incorrect.

e.g. if you have this in a template...

{include file="Directory/Views/desktop/partials/filters/$filter.tpl"}

The output in Debugbar becomes...

Directory.Views.desktop.partials.filters.".((string)$_smarty_tpl->tpl_vars['filter']->value)."

coveralls commented 7 years ago

Coverage increased (+1.3%) to 100.0% when pulling 7a670536d325954ba3d1a1adce7042ca58492174 on feature-issue44 into 4dd647b6287ef67e72742c3c7d4432463cd88171 on master.

ytake commented 7 years ago

solved!

coveralls commented 7 years ago

Coverage increased (+1.3%) to 100.0% when pulling fda3e9dd589043da49cc9b92714b05ac2e306629 on feature-issue44 into 4dd647b6287ef67e72742c3c7d4432463cd88171 on master.

JayBizzle commented 7 years ago

Great stuff!

I'll give it a test tomorrow when I'm back in the office.

JayBizzle commented 7 years ago

Just tested this locally. Looks good to go!