search

ytakzk / Fusuma

Instagram-like photo browser and a camera feature with a few line of code in Swift.
MIT License
2.46k stars 340 forks source link

Wrong crop height ratio according to available modes. #280

Closed melancholy13 closed 5 years ago

melancholy13 commented 5 years ago

It is strange for me: 

fusuma.cropHeightRatio = 1.0
fusumaCropImage = true

I expect the photo to be square. And if: 

fusuma.availableModes = [FusumaMode.camera, FusumaMode.library]

or 

fusuma.availableModes = [FusumaMode.video, FusumaMode.camera]

Everything is good, the area of the photo and the photo itself are square. But if:

fusuma.availableModes = [FusumaMode.camera]

Despite cropHeightRatio and fusumaCropImage, photo area and photo itself are rectangular.

FrancoisObob commented 5 years ago

Same issue here : default ratio is not 1:1 for camera mode.

nkezhaya commented 5 years ago

I'll get to it as soon as I can. In the meantime: pull requests are appreciated

FrancoisObob commented 5 years ago

https://github.com/ytakzk/Fusuma/pull/286

nkezhaya commented 5 years ago

@FrancoisObob Merci !

FrancoisObob commented 5 years ago

new PR only for this fix :)

nkezhaya commented 5 years ago

Fixed in 1.3.2.