ytdl-org / youtube-dl

Command-line program to download videos from YouTube.com and other video sites
http://ytdl-org.github.io/youtube-dl/
The Unlicense
132.28k stars 10.03k forks source link

ndtv support broken #19096

Open mayureshw opened 5 years ago

mayureshw commented 5 years ago

Please follow the guide below


Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.01.30.1. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

Before submitting an issue make sure you have:

What is the purpose of your issue?


The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

$ youtube-dl -v "https://www.ndtv.com/video/shows/walk-the-talk/walk-the-talk-with-george-fernandes-aired-june-2003-287880"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.ndtv.com/video/shows/walk-the-talk/walk-the-talk-with-george-fernandes-aired-june-2003-287880']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.01.30.1
[debug] Python version 2.7.15 (CPython) - NetBSD-8.0_RC1-amd64-x86_64-64bit-ELF
[debug] exe versions: ffmpeg 4.0, ffmpeg3 3.4.2, ffmpeg4 4.0, ffprobe3 3.4.2, ffprobe4 4.0
[debug] Proxy map: {}
[NDTV] 287880: Downloading webpage
ERROR: Unable to extract video filename; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/pkg/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 793, in extract_info
    ie_result = ie.extract(url)
  File "/usr/pkg/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 508, in extract
    ie_result = self._real_extract(url)
  File "/usr/pkg/lib/python2.7/site-packages/youtube_dl/extractor/ndtv.py", line 91, in _real_extract
    r"(?:__)?filename\s*[:=]\s*'([^']+)'", webpage, 'video filename')
  File "/usr/pkg/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 983, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video filename; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Description of your issue, suggested solution and other information

ndtv was a supported site, though of late the support is broken, most probably something changed on the site.

rawcoder commented 5 years ago

I have written a fix. You can find it here: https://github.com/rawcoder/youtube-dl/tree/ndtv_fixes

I will send a PR once it is cleaned up. Not sure if @dstftw would be ready to merge it in its current state.