ealgase
commented
5 years ago As far as I can tell the Comcast_SSO doesn't work at all (didn't work for me on Simpsons World).
Closed joshtish closed 5 years ago
ealgase
commented
5 years ago As far as I can tell the Comcast_SSO doesn't work at all (didn't work for me on Simpsons World).
ealgase
commented
5 years ago This also is related/duplicate of #11257, #11538, and #16630.
joshtish
commented
5 years ago Could well be a dupe of that last one for sure - the "Automatically signing you in" is the page I get when browsing from my home network - and it might be hitting that and failing out in the same way as #16630.
joshtish
commented
5 years ago Just to follow-up for people finding this in the future. I tested on an external connection where I don't get automatically signed-in, and things work as one would expect. So, oddly enough... if you want to use your comcast credentials, you can't be in your own home, or if you are home, you must use VPN.
tv21
commented
5 years ago For those running from source code or compiling your own, the quick fix for Comcast Xfinity is to use this version of adobepass.py:
https://raw.githubusercontent.com/bhamboss/youtube-dl/patch-1/youtube_dl/extractor/adobepass.py
That is from https://github.com/bhamboss/youtube-dl/blob/patch-1/youtube_dl/extractor/adobepass.py and I can confirm this works with Xfinity's new login if you are coming in from an Xfinity IP address.
Just to be clear, Xfinity authenticates differently if you are coming in from one of their IP addresses vs. if you are coming in from the IP of some other provider. I tested the above patch coming from an Xfinity IP. I did NOT test it from another provider's IP.
If I run diff -u on the original and patched files I get this:
$ diff -u adobepass.py.original adobepass.py.patched
--- adobepass.py.original 2018-10-17 01:22:56.000000000 -0400
+++ adobepass.py.patched 2019-04-23 08:53:36.000000000 -0400
@@ -1433,6 +1433,14 @@
provider_redirect_page, 'oauth redirect')
self._download_webpage(
oauth_redirect_url, video_id, 'Confirming auto login')
+ elif 'automatically signed in with' in provider_redirect_page:
+ # Seems like comcast is rolling up new way of automatically signing customers
+ oauth_redirect_url = self._html_search_regex(
+ r'continue:\s*"(https://oauth.xfinity.com/oauth/authorize\?.+)"',
+ provider_redirect_page, 'oauth redirect (signed)')
+ # Just need to process the request. No useful data comes back
+ self._download_webpage(
+ oauth_redirect_url, video_id, 'Confirming auto login')
else:
if '<form name="signin"' in provider_redirect_page:
provider_login_page_res = provider_redirect_page_res
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like this:[x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2019.04.17. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the
-vflag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):Description of your issue, suggested solution and other information
Attempting to use youtube-dl on syfy using my comcast credentials results in a "Unable to extract post url" bug. It asked me to file a bug here, so I'm filing a bug here.