Open someziggyman opened 3 years ago
The failing URL https://everythingfox.tumblr.com/post/656964996113301504/i-am-fierce-via needs the Referer
header to be added when fetching the iframe
URL (the value being the URL of the original page).
Also, the page has 10 video iframes, but the extractor only finds the first (top) one. The extractor should default to selecting the first video unless a playlist is requested, but, because --yes-playlist
isn't distinguishable from failing to say --no-playlist
, there is no way for yt-dl to do that.
Most extractors follow the browser's access paths, so that we know the extracted item corresponds to the resource indicated by the extracted URL.
When using an API that isn't directly invoked in the browser access path, we need to understand what metadata is available, in case the webpage needs to be searched for missing fields, and to what extent the API is supported/documented.
In this case, just pulling the yt-dlp fixes looks like a simple solution and would avoid duplicate code.
If the site/app has a function like that I'd count it as a documented API. But such deep link URLs can be handled by adding an extractor, or extending an existing URL pattern. The default approach I described follows since yt-dl pre-dates the smartphone app era.
Of course, yt-dl has its own custom links, such using just the YT ID, or ytsearchall:...
, or kaltura:partner:id
.
Checklist
Verbose log
Description
Test link: https://everythingfox.tumblr.com/post/656964996113301504/i-am-fierce-via same link but a bit different format: https://everythingfox.tumblr.com/post/656964996113301504/embed
However these links work, even though the structure seems to be the save (subdomain, post, ID, video name): https://dumbasscats.tumblr.com/post/638777506589229056/a-true-captain-goes-down-with-his-ship-via-reddit https://cuteanimalshare.tumblr.com/post/656841552268869632/who-doesnt-like-ginger-cats