search

ytdl-org / youtube-dl

Command-line program to download videos from YouTube.com and other video sites
http://ytdl-org.github.io/youtube-dl/
The Unlicense
131.27k stars 9.94k forks source link

Spotify support confusing #31037

Open natedogith1 opened 2 years ago

natedogith1 commented 2 years ago

Checklist

Description

supportedsites.md says spotify is supported, but it fails with the typical open.spotify.com links (related issues: #30180, #29722, #28660). The documentation should be updated to make it clearer that this use case isn't supported.

dirkf commented 2 years ago

Spotify is supported. The extractor knows about /episode/ and /show/ URLs.

Otherwise, duplicate of #29722, as you have identified.

The yt-dlp extractor also finds URLS with additional initial embed or embed-podcast before the URL type (as above) and this could easily be back-ported.

Otherwise, is it worth adding a special SpotifyUnsupportedIE to report on unsupported Spotify URL patterns?

rautamiekka commented 2 years ago

Otherwise, is it worth adding a special SpotifyUnsupportedIE to report on unsupported Spotify URL patterns?

Let's put it this way: is the use case of "prevent (or at least heavily decrease) the endless stream of ticket dupes and uncertainty that can only be confirmed by spending a very boring hour or 2 reading both the official Spotify docs and the ytdl source code ?" worth it ?

gamer191 commented 2 years ago

Otherwise, is it worth adding a special SpotifyUnsupportedIE to report on unsupported Spotify URL patterns?

I once started working on an yt-dlp IE here to report a warning whenever the user inputs a DRM-protected url, and then fall back on the generic extractor. Currently it's abandoned, but it could probably be used as a template for a bigger UnsupportedSitesIE, which could include the Spotify unsupported IE.

Now that I think about it, I might continue working on it some time soon.

PS: actually, Pukkandan wrote most of the code, but it's in my repo because I was going to continue working on it (but then I forgot about it)

gamer191 commented 2 years ago

Wait, do you still want to work on the DrmProtectedIE @sulyi?

sulyi commented 2 years ago

want to work on the DrmProtectedIE

That was someone else's idea, I just joked about implementing it. It's more of a in-fracture thing which is my jam.

discord

KarlRW commented 1 year ago

Just to clear this up, are things like the JRE podcast possible to download? It's available for free. Trying to download the episodes because spotify has so many issues it's become unusable for me.

Here is the output from the embed feature for an example video I am trying to download:

<iframe style="border-radius:12px" src="https://open.spotify.com/embed/episode/4OXGSwuHYf0gHtJxGWIbLL/video?utm_source=generator" width="624" height="351" frameBorder="0" allowfullscreen="" allow="autoplay; clipboard-write; encrypted-media; fullscreen; picture-in-picture" loading="lazy"></iframe>
dirkf commented 1 year ago

Your open.spotify.com link is marked as "extractor not working" in yt-dlp and gives "Unsupported URL" in yt-dl.

gamer191 commented 1 year ago

https://open.spotify.com/embed/episode/4OXGSwuHYf0gHtJxGWIbLL/video?utm_source=generator

This link works after disabling DRM, so it would be possible to add support for

Whether it would be merged is another question. I'd be interested @pukkandan's take on that question, since he's generally opposed to Spotify support, due to Spotify's history of legal action, but that particular video also plays DRM-free without any workaround. I'd also love to hear @dirkf's opinion (and while we're at it, @dirkf's opinion on https://github.com/yt-dlp/yt-dlp/pull/4935, which wasn't merged due to Deezer's DMCA history, along with some licensing issues)

PS: You're lucky I'm half asleep and didn't realise that JRE was short for Joe Rogan Extremism Experience

pukkandan commented 1 year ago

I'd be interested @pukkandan's take on that question

https://github.com/yt-dlp/yt-dlp/pull/4935#issuecomment-1460160547

dirkf commented 1 year ago

My feeling is that effort is unlikely to be devoted to sites where little of the content is accessible, since it will only lead to disappointed users, and that such effort could be used on more useful extractors.

Better to person up and admit that some other technique, maybe involving a microphone or a headphone socket in this case, would be more generally effective.

gamer191 commented 1 year ago

Better to person up and admit that some other technique, maybe involving a microphone or a headphone socket in this case, would be more generally effective.

or possibly https://github.com/yt-dlp/yt-dlp/issues/1368#issuecomment-955783122, but that's legally quite risky, especially since I'm pretty sure ZSpotify got DMCAed

dirkf commented 1 year ago

It wasn't very effective if so, as many heads of the ZSpotify Hydra remain. But also GPL.

gamer191 commented 1 year ago

It wasn't very effective if so, as many heads of the ZSpotify Hydra remain.

Um, what?

unsubscribing from this thread, as it seems to have fallen victim to the typical crap. no decent examples, no accounts, babies crying about DRM. at me or contact me privately if something changes. peace.

I was unaware that pointing out that sending instructions to workaround Spotify's DRM counted as "babies crying about DRM". I guess I learn something new everyday!

gamer191 commented 1 year ago

@dirkf while we're discussing DRM, what's your opinion on yt-dlp/yt-dlp#4935, which wasn't merged due to Deezer's DMCA history (that PR was rejected anyway, because it's allegedly been plagurised and hence doesn't fall under unlicense, but that's not the main issue, and that can be solved by rewriting the pr)

ghost commented 1 year ago

which wasn't merged due to Deezer's DMCA history

I wish people would stop with the scare tactics. that request was filed two years ago. since then plenty of implementations still exist in the wide open:

https://github.com/search?q=deezer+pushed:>2022-07-16+stars:>9

theres caution, and then theres just silliness.

eflister commented 9 months ago

spotify is listed as supported, but elsewhere in the issue tracker it is claimed not to be because of drm. which is it? can the doc be updated to clearly state whether it is supported? if so, support playlists please. https://github.com/ytdl-org/youtube-dl/issues/29722#issuecomment-1853262541

dirkf commented 9 months ago

The extractor only supports podcasts. Music on spotify is DRM protected and cannot be supported.