ytdl-org / youtube-dl

Command-line program to download videos from YouTube.com and other video sites
http://ytdl-org.github.io/youtube-dl/
The Unlicense
131.89k stars 10k forks source link

update for extractor/hentaistigma.py - should fix issue 25019 -- only look at commit 105d32b58cbe06b65439454a4345b5bd635ef0e5 #32940

Closed ifixthat-gmx closed 1 week ago

ifixthat-gmx commented 1 week ago

Before submitting a pull request make sure you have:

I made this PR so the necessary changes/modifications are known to you devs - I suggest you reject this PR and just take the needed changes from commit 105d32b58cbe06b65439454a4345b5bd635ef0e5 :) Therefore I skipped the next 2 :

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

What is the purpose of your pull request?


Description of your pull request and other information

This is my 1st attempt to contribute to youtube-dl. This should/could fix/improve the hentai.animestigma.com extractor (see https://github.com/ytdl-org/youtube-dl/issues/25019).

I repeat : I made this PR so the necessary changes/modifications are known to you devs - I suggest you reject this PR and just take the needed changes from commit 105d32b58cbe06b65439454a4345b5bd635ef0e5 :) + Only checkout the changes in commit updated extractor/hentaistigma.py and ignore the other commit (I have not figured out how to do cherry-pick-pull-requests).

ifixthat-gmx commented 1 week ago

This was the first extractor that I modified - so I thought it would be a good candidate to do the first PR . You probably want to just take the changes from the extractor-file and put them into your implementation instead of merging this PR though. I tidied up alot already but there are still some remnants from my developing that I left in for my reference.

ifixthat-gmx commented 1 week ago

here the cherry-picked temporary branch : https://github.com/ifixthat-gmx/ytdl-org---youtube-dl/tree/tmp-hentaistigma I might redo the PR at some later point with this branch:)

ifixthat-gmx commented 1 week ago

gonna redo PR with branch https://github.com/ifixthat-gmx/ytdl-org---youtube-dl/tree/tmp-hentaistigma