Open rg3 opened 13 years ago
Originally by anonymous:
This would be an amazing feature! Please implement it :)
The closest thing I can find for this is: http://code.google.com/apis/youtube/js_api_reference.html#Playback_status
Possibly we could write a small virtualization just for the "player.getVideoBytesTotal():Number" function.
Or using "json-c" we could use some math and calculate the size of the video
http://code.google.com/apis/youtube/2.0/developers_guide_jsonc.html
No need to use that. The size is known in the moment you're ready to download (remember the download progress bar).
Diregard, I'm a complete moron. I need to actually get on MY computer when I'm posting, and some more sleep :(
youtube-dl was in dire need of a --get-filesize option and I needed it now, so I just wrote it. your welcome. I don't know how github works yet so maybe someone else can request this be added.
@acuity The best way would be a github pull request, since that can be commented line-by-line. However, you can also provide your own git repository, or a patches. Providing a link to the changed version means I have to create the patch manually.
Note that why your implementation works in some cases, it can also output the undocumented None
and any non-integer values. Additionally, it doesn't work for RTMP resources (and silently downloads these). Also, depending on the OS and its configuration, it may actually download quite a significant chunk of data and then throw it away - you're sending an HTTP GET request, read data, and then just leave it. And it creates the output file even if --get-filesize
is given.
However, since --get-filesize
seems to get requested over and over, I'll think about implementing it. My main issue with it is that I can't see a use case. @sivaramn mentioned ISP bandwidth limitations in #190, and that may be one.
indeed, you won't believe the plans here. 10Gb at 512kbs capped and then 256 kbs beyond 10gb. And that's the 'unlimited' plan
Yea, I just did only what was necessary to make it work for my project. I just needed to set a download limit on youtube video size.
Another thing I added was a cheat to get around the youtube bandwidth limitation. After downloading about 1MB of video, it limits your bandwidth severely. So I added another option --partial that only downloads 1MB of video, then resets the connection using the partial file. This lets you utilize youtube's bandwidth, and is about 60 times faster after the first 1MB (on my server). It probably has more problems outside what I'm using it for though, so I probably shouldn't share that version.
@phihag Another use case for --get-filesize? Determining the size of many videos in advance, like when downloading a complete YouTube channel. Not as a single-option-there-is-your-total-download-size-solution, but with reasonable parsing effort afterwards. For single videos, you can always start the download and stop immediately. For multiple videos (read: possibly hundreds) that's not a practical way to do it. --skip-download skips the download before actually getting/printing the size. So, why would I enjoy this feature? I have a medium speed internet connection, too fast to just let it run overnight (might fill up hard disk to the brim if there are large-ish videos that I'm not aware of), but also too slow to just get stuff on demand without annoying everybody, killing VOIP, etc. So I'd like to know how much total DL size will be, so that I can pull a reasonable amount of videos during the idle time at night - finishing before the first user starts in the morning, not accidentally filling my HDD, not wasting precious download time.
Out of curiosity, is this a lot harder to implement than it sounds? I mean, as far as I know, the progress indicators always contain the file size, so it seems like it should be pretty easy. Meanwhile, this request's been open for literally over five years…
Well, if you have a progress indicator, then yes, that is pretty obvious.
But there are other cases, like RTMP, HLS, HDS, all that streaming crap ;)
You don't have a single video file, instead there are lots of fragments. You somehow could fetch the sizes of these, I think, but yes, it is a lot harder to implement than a single, direct download ;)
@Hrxn Maybe --get-size
could print just the sizes that are available (so not the ones for streams, for example), and cause youtube-dl
to exit unsuccessfully if some of them weren't available?
Yes, that should be possible, but as someone stated earlier, I'm also not sure about a good use case..
Hi,
1°) I suggest to force the user to add the format along with the --get-size
so that there might be only one result:
youtube-dl --get-size -f 18 http://www.youtube.com/watch?v=29S1T7RNHGM
2°) If YouTube does not provide the filesize information for the specified format, you could still get it from the Content-Length
by doing a HTTP HEAD request (you don't have to download the file :) ), example with python urllib
:
$ python
Python 2.7.8 (default, Jun 18 2015, 18:54:19)
[GCC 4.9.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import urllib, os
>>> link = "http://ftp.lip6.fr/pub/linux/distributions/Ubuntu/releases/trusty/ubuntu-14.04.4-desktop-amd64.iso"
>>> meta = urllib.urlopen(link).info()
>>> print "Content-Length:", meta.getheader("Content-Length")
Content-Length: 1069547520
>>>
Another example with python httplib
(still without downloading the file :) ) :
$ python
Python 2.7.8 (default, Jun 18 2015, 18:54:19)
[GCC 4.9.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import httplib
>>> url = "http://cdimage.ubuntu.com/kubuntu/releases/14.04.4/release/kubuntu-14.04.4-desktop-amd64.iso"
>>> domain = url.split("//")[-1].split("/")[0]
>>> conn = httplib.HTTPConnection(domain)
>>> conn.request("HEAD", url)
>>> response = conn.getresponse()
>>> print "Content-Length:", response.getheader('content-length')
Content-Length: 1105133568
>>>
Even easier with python requests
:) (Requests: HTTP for Humans):
$ python
Python 2.7.8 (default, Jun 18 2015, 18:54:19)
[GCC 4.9.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> url = "http://cdimage.ubuntu.com/kubuntu/releases/14.04.4/release/kubuntu-14.04.4-desktop-amd64.iso"
>>> r = requests.head(url)
>>> print r.headers['content-length']
1105133568
If we are still looking for use cases, I often have to send videos over messaging applications (whatsapp, messenger etc.), and it would be useful to know if there is a version that is within the file size limits when using the -F flag.
I would love a "--size" flag for estimating the final size of a download. Ideally this would act as a dry run, returning the approximate size of a download.
AtomicParsley 0.9.0 in FreeBSD apparently does not embed thumbnails in video sizes over 4GB. On my arch linux it has AtomicParsley 0.9.6 and it works fine, but FreeBSD hasn't updated AtomicParsley yet. Youtube doesn't give file sizes for a lot of formats like mp4_dash or webm_dash containers. If youtube-dl had a way to get file size it would help avoid embedding files over 4GB.
this works in yt-dlp using --print %(filesize,filesize_approx)s
A similar thing should be available in yt-dl shortly, even with the fallback list, since that's just a change from info_dict[key]
to dict_get(info_dict, key_or_keys)
, or similar.
However the problem is that filesize(_approx)?
aren't necessarily available or calculated, nor is tbr
. We also need something like this (which yt-dlp does have, differently expressed):
if (info_dict.get('tbr') is None
and info_dict.get('vbr' if info_dict.get('vcodec') != 'none' else 'abr') is not None):
info_dict['tbr'] = sum(info_dict.get(br, 0) for br in ('vbr', 'abr'))
if (dict_get(info_dict, ('filesize', 'filesize_approx')) is None
and info_dict.get('duration') is not None
and info_dict.get('tbr') is not None):
info_dict['filesize_approx'] = int(1024 * info_dict['duration'] * info_dict['tbr'])
Was: http://bitbucket.org/rg3/youtube-dl/issue/141/
If the file size was outputted it would be possible to script youtube-dl to test if the current video the the harddrive is in the best possible quality.
It happens that Youtube re-encode videos, and with higher resolution, so being able to extract the file size from youtube-dl would be very useful.
File size in bytes would be preferred.