search

ytgov / travel-authorization

0 stars 3 forks source link

Travel Desk Request missing fields in grid #113

Open dpdavids opened 3 months ago

dpdavids commented 3 months ago

Describe the bug On the https://travel-auth-dev.ynet.gov.yk.ca/travel-desk grid screen the user, department and branch fields are not being populated. To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://travel-auth-dev.ynet.gov.yk.ca/travel-desk'
  2. See issue

Expected behavior The traveler name, department and branch should be populated.

Screenshots

image

Desktop (please complete the following information):

Add any other context about the problem here.

klondikemarlen commented 1 month ago

Updated steps to reproduce.

  1. In the top right click on the kebab menu and select Administration.
  2. Click on the User Management entry.
  3. Find your user in the table and click on them.
  4. Set your user's first name, last name, and department and then click save.
  5. Note that there is no way to edit your division, branch or unit via the UI.
  6. In the database, find your user's record update the department, division, and branch to match something like Health and Social Services -> Community and Primary Care -> Integrated Health Services This information can be found in the YgDepartments table.
  7. Go to your profile via the top nav kebab menu and refresh the page to check that your details are correct.
  8. Go to the My Travel Request page via the top drop down nav.
  9. Click on the "+ Travel Authorization" button to create a travel authorization.
  10. Fill in the first two sections and make sure that your travel method is "Aircraft".
  11. Generate the estimate via the call-to-action button.
  12. Submit to yourself as the supervisor.
  13. Go to the Manager View via the top drop down nav.
  14. Find your approval in the Pending Approvals section and click on it.
  15. Scroll down to the bottom and approve it via the button and dialog.
  16. Go back to the "My Travel Request" page via the top drop down nav.
  17. Find you travel request in the table and click the "Submit Travel Desk Request button.
  18. Fill in all required fields and submit the request.
  19. Go to the "Travel Desk" page via the top drop down nav.
  20. Find the request in the Travel Desk Requests table, and note that the department and branch are missing.

    I fixed the Name column in a previous PR.

klondikemarlen commented 1 month ago

Note that the "Travel Start Date" column is returning "Dec 29 1969" which is unlikely to be correct. The "Travel End Date" column is blank.

I'll fix these as well.