search

ythri / tcresearch

Thaumcraft 4.1 Research Helper
72 stars 76 forks source link

Adding alphabetical order for aspects #21

Closed chilled-kroete closed 10 years ago

Smashman commented 10 years ago

The current sorting is actually the tier sorting that the game acknowledges. It used to be alphabetical, but I changed it to this.

@ythri, what are your thoughts?

ythri commented 10 years ago

Actually, I think I prefer the alphabetical sorting, because if you have an aspect you want to connect, you always know its name, but usually not its tier.

I will probably merge this pull request tomorrow ... is that ok?

Smashman commented 10 years ago

It's your project! Though after thinking about it, I agree. :+1:

ythri commented 10 years ago

Ok, I merged it, thank you @x-mtd for the pull request.

One small note: I changed the compare function a tiny bit to return 0 for equal aspects (previously it would return 1). Not sure if this needed for sorting, but it felt strange without.

Smashman commented 10 years ago

Am I crazy, or does this completely not work?

ythri commented 10 years ago

Oh, now I see it. It does work, but only for the lists (From and To), not for the selection of available aspects. What I would find best: The order that you proposed in issue #23 for the selection of the available aspects, and pure alphabetical order for the lists From and To. What do you think?

Edit: Especially if we can ever fix issue #15, anything but alphabetical order would be awkward for the lists.

Smashman commented 10 years ago

Now in my pull request.