ytnobody / p5-Net-Azure-NotifcationHubs

A Client Class for Azure Notification Hubs
Other
0 stars 1 forks source link

Undeclared dependency HTTP::Request #3

Closed eserte closed 6 years ago

eserte commented 6 years ago

See subject. Tests fail if it is not installed:

Output from './Build test':

#   Failed test 'use Net::Azure::NotificationHubs;'
#   at t/00_compile.t line 4.
#     Tried to use 'Net::Azure::NotificationHubs'.
#     Error:  Can't locate HTTP/Request.pm in @INC (you may need to install the HTTP::Request module) (@INC contains: ... .) at /tmpfs/.cpan-build-cpansand/2018061103/Net-Azure-NotificationHubs-0.04-kdEU1j/blib/lib/Net/Azure/NotificationHubs.pm line 10.
# BEGIN failed--compilation aborted at /tmpfs/.cpan-build-cpansand/2018061103/Net-Azure-NotificationHubs-0.04-kdEU1j/blib/lib/Net/Azure/NotificationHubs.pm line 10.
# Compilation failed in require at t/00_compile.t line 4.
# BEGIN failed--compilation aborted at t/00_compile.t line 4.
# Looks like you failed 1 test of 1.
t/00_compile.t .............. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
... etc ...
ytnobody commented 6 years ago

This is an affect of refactor in 0.04.

I forgot to remove use HTTP::Request; from Net/Azure/NotificationHubs.pm .

Then, I shipped 0.05. However, It wasn't contains a commit about fix this issue.

Afterwords, I shipped 0.06 carefully. This release avoid the issue.

https://travis-ci.org/ytnobody/p5-Net-Azure-NotifcationHubs

Thank you for tell.