portability of SystemIncludeDirectories_Case

[GoogleCodeExporter]

r773

On Debian the system headers are being moved to multiarch directories, which 
breaks the test SystemIncludeDirectories_Case.

Work around by making this test conditional on the existence of 
/usr/include/sys/types.h, like the CPlusPlus variant.  See attached.

Is this test still meaningful?  If so, perhaps the better solution is to 
determine the actual path by also looking for /usr/include/$(gcc 
-print-multiarch)/types.h.  The GCC manual says to not use -I to access vendor 
supplied header files [1], presumably because this may interfere with some 
special handling.

[1] <http://gcc.gnu.org/onlinedocs/gcc-4.7.3/gcc/Directory-Options.html>

Also on Debian we are seeing two other test cases fail due to gcc returning 4 
instead of 1.  This looks like -pass-exit-codes, but I have not traced the 
source yet.

Original issue reported on code.google.com by mand...@gmail.com on 6 May 2013 at 1:18

Attachments:

• 13_test-systeminclude.patch

[GoogleCodeExporter]

I think the test is still meaningful; despite the advice in the GCC manual, it 
is not uncommon for people to use "-I" to include headers from system header 
directories, and distcc should continue to support that to the same extent that 
the underlying compiler supports it.

Your patch looks fine as a work-around.  Do you want to go ahead and commit it?
I have added you to the list of users who have permission to commit changes.
See <https://code.google.com/p/distcc/source/checkout> for details on how to 
check out the SVN repository.

Original comment by fergus.h...@gmail.com on 7 May 2013 at 11:34

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r775.

Original comment by mand...@gmail.com on 8 May 2013 at 2:22

• Changed state: Fixed